Use PME for ESRP release #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hallipr
commented
Mar 3, 2025
hallipr
commented
- Update release task to v9
- Use PME managed identity for ESRP requests
- Update release task to v9 - Use PME managed identity for ESRP requests
There was a problem hiding this comment.
PR Overview
This PR upgrades the ESRP release task from version 7 to version 9 and updates the configuration to use the PME managed identity for ESRP requests.
- Updated the EsrpRelease task version from @7 to @9
- Changed the ConnectedServiceName and adjusted related input parameters to support the PME managed identity
- Modified key vault and certificate settings to be consistent with the PME configuration
Reviewed Changes
| File | Description |
|---|---|
| azure-pipelines/release-stage.yml | Upgraded ESRP task version and updated inputs for PME identity |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
azure-pipelines/release-stage.yml:46
- When using a managed identity (UseManagedIdentity: true), verify whether the ClientId input is still necessary according to the updated documentation for EsrpRelease@9. If not required, consider removing it to avoid potential misconfiguration.
ClientId: '5f81938c-2544-4f1f-9251-dd9de5b8a81b'
8 tasks
weshaggard
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.